-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:modify style #981
fix:modify style #981
Conversation
WalkthroughThis pull request focuses on UI refinements across multiple files, primarily addressing styling and layout improvements. The changes involve adjusting CSS properties in Changes
Suggested labels
Suggested reviewers
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/plugins/materials/src/meta/block/src/BlockGroup.vue (1)
432-432
: Explicit width might limit flexible designs
Currently, setting.tiny-input__inner
to a fixedwidth: 180px;
enforces a rigid layout. If there are future design changes or localized text expansions, this might not be optimal. Consider making this width configurable or using a max-width to retain responsiveness.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
packages/common/component/PluginSetting.vue
(1 hunks)packages/plugins/materials/src/meta/block/src/BlockGroup.vue
(3 hunks)packages/theme/base/src/component-common.less
(3 hunks)
✅ Files skipped from review due to trivial changes (1)
- packages/common/component/PluginSetting.vue
🔇 Additional comments (5)
packages/plugins/materials/src/meta/block/src/BlockGroup.vue (2)
442-444
: Improved padding for .tiny-button
These adjustments help ensure more compact spacing for confirmation buttons. This looks consistent with the overall style approach.
462-467
: Efficient text truncation
Defining width
, overflow
, text-overflow
, and white-space
ensures long group names are truncated with an ellipsis. This aligns well with the PR’s objective to handle block name lengths gracefully.
packages/theme/base/src/component-common.less (3)
15-17
: Space for dropdown icons
Increasing padding-right
to 30px in .tiny-input__inner
ensures sufficient space for dropdown icons, preventing layout overlap. This change is consistent with the PR’s stylistic goals.
504-504
: Consistent numeric field padding
The reduced padding from 0 42px 0 12px
to 0 20px 0 12px
is more compact, aligning numeric inputs with the rest of the form styling. This helps maintain visual consistency.
525-525
: Unit label spacing
Adjusting padding for .tiny-numeric__input-inner
ensures the unit label is properly spaced. This minor tweak improves readability and matches the new design patterns.
English | 简体中文
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Background and solution
1.区块名称长度样式调整

2.样式宽度悬浮和直接显示宽度一致

What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit